Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple updated to make isempty workable for each data structures #50

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

alefcastelli
Copy link
Collaborator

Without theses changes, PowerFlows.jl was throwing an error related to Base.show. The following changes fix the issue.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

Performance Results

Version Precompile Time
Main 3.565418137
This Branch 3.460000703
Version Execute Time
Main-Build PTDF First 8.505126784
Main-Build PTDF Second 0.252331529
Main-Build Ybus First 0.557896672
Main-Build Ybus Second 0.011784611
Main-Build LODF First 0.756064742
Main-Build LODF Second 0.374312556
This Branch-Build PTDF First 8.197863861
This Branch-Build PTDF Second 0.238768694
This Branch-Build Ybus First 0.526281678
This Branch-Build Ybus Second 0.010805652
This Branch-Build LODF First 0.72976177
This Branch-Build LODF Second 0.370118303

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #50 (045cbe7) into main (c48e12f) will decrease coverage by 1.00%.
The diff coverage is 0.00%.

❗ Current head 045cbe7 differs from pull request most recent head bb4904b. Consider uploading reports for the commit bb4904b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   83.59%   82.60%   -1.00%     
==========================================
  Files          14       14              
  Lines        1018     1029      +11     
==========================================
- Hits          851      850       -1     
- Misses        167      179      +12     
Flag Coverage Δ
unittests 82.60% <0.00%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/PowerNetworkMatrix.jl 26.61% <0.00%> (ø)
src/virtual_lodf_calculations.jl 89.53% <0.00%> (-6.72%) ⬇️
src/virtual_ptdf_calculations.jl 89.28% <0.00%> (-6.87%) ⬇️

... and 1 file with indirect coverage changes

for mat in [a, ba, aba]
test_value = false
try
show(@eval a);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
show(@eval a);
show(@eval a)

Comment on lines 102 to 103

end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
end
end

# test show
test_value = false
try
show(vlodf);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
show(vlodf);
show(vlodf)

end
end
@test test_value

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

# test show
test_value = false
try
show(vptdf);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
show(vptdf);
show(vptdf)

end
end
@test test_value

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

@jd-lara
Copy link
Member

jd-lara commented Aug 24, 2023

@alefcastelli can you post the error. There is no reason for PF's to be throwing an error because of show methods.

@jd-lara jd-lara merged commit 966c1c3 into main Aug 28, 2023
5 of 7 checks passed
@jd-lara jd-lara deleted the problem_with_isempty_2 branch August 28, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants